lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/6] staging: r8188eu: remove spaces before tabs
    On Sat, Apr 02, 2022 at 03:50:48AM -0500, Rebecca Mckeever wrote:
    > Conform to Linux kernel coding style.
    >
    > Reported by checkpatch:
    >
    > WARNING: please, no space before tabs
    >
    > Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
    > ---
    > drivers/staging/r8188eu/core/rtw_cmd.c | 16 ++++++++--------
    > 1 file changed, 8 insertions(+), 8 deletions(-)
    >
    > diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
    > index 832bf25b1a83..8ae25cb4246b 100644
    > --- a/drivers/staging/r8188eu/core/rtw_cmd.c
    > +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
    > @@ -548,9 +548,9 @@ u8 rtw_joinbss_cmd(struct adapter *padapter, struct wlan_network *pnetwork)
    >
    > phtpriv->ht_option = false;
    > if (pregistrypriv->ht_enable) {
    > - /* Added by Albert 2010/06/23 */
    > - /* For the WEP mode, we will use the bg mode to do the connection to avoid some IOT issue. */
    > - /* Especially for Realtek 8192u SoftAP. */
    > + /* Added by Albert 2010/06/23 */

    In follow on patches you can delete these sorts of "Added by Albert 2010"
    comments.

    > + /* For the WEP mode, we will use the bg mode to do the connection to avoid some IOT issue. */
    > + /* Especially for Realtek 8192u SoftAP. */
    > if ((padapter->securitypriv.dot11PrivacyAlgrthm != _WEP40_) &&
    > (padapter->securitypriv.dot11PrivacyAlgrthm != _WEP104_) &&
    > (padapter->securitypriv.dot11PrivacyAlgrthm != _TKIP_)) {
    > @@ -1010,7 +1010,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
    > u8 res = _SUCCESS;
    >
    > /* if (!pwrctrlpriv->bLeisurePs) */
    > - /* return res; */
    > + /* return res; */

    And this commented out code.

    >
    > if (enqueue) {
    > ph2c = kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC);
    > @@ -1151,8 +1151,8 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
    > }
    >
    > pdrvextra_cmd_parm->ec_id = P2P_PROTO_WK_CID;
    > - pdrvextra_cmd_parm->type_size = intCmdType; /* As the command tppe. */
    > - pdrvextra_cmd_parm->pbuf = NULL; /* Must be NULL here */
    > + pdrvextra_cmd_parm->type_size = intCmdType; /* As the command tppe. */
    ^
    s/tppe/type/. It's noting the "size = type". (Which is an ugly hack).

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2022-04-04 14:17    [W:3.221 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site