lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/clk/mediatek/clk-pll.c:418:23: warning: variable 'base' set but not used
Hi Chen-Yu,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3123109284176b1532874591f7c81f3837bbdc17
commit: 6dd199064dd86127030b5bc59d4058370b6c8310 clk: mediatek: pll: Implement unregister API
date: 7 weeks ago
config: sh-buildonly-randconfig-r002-20220404 (https://download.01.org/0day-ci/archive/20220404/202204041904.XbBQEwTe-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6dd199064dd86127030b5bc59d4058370b6c8310
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 6dd199064dd86127030b5bc59d4058370b6c8310
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/clk/mediatek/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/clk/mediatek/clk-pll.c: In function 'mtk_clk_unregister_plls':
>> drivers/clk/mediatek/clk-pll.c:418:23: warning: variable 'base' set but not used [-Wunused-but-set-variable]
418 | __iomem void *base = NULL;
| ^~~~


vim +/base +418 drivers/clk/mediatek/clk-pll.c

414
415 void mtk_clk_unregister_plls(const struct mtk_pll_data *plls, int num_plls,
416 struct clk_onecell_data *clk_data)
417 {
> 418 __iomem void *base = NULL;
419 int i;
420
421 if (!clk_data)
422 return;
423
424 for (i = num_plls; i > 0; i--) {
425 const struct mtk_pll_data *pll = &plls[i - 1];
426
427 if (IS_ERR_OR_NULL(clk_data->clks[pll->id]))
428 continue;
429
430 /*
431 * This is quite ugly but unfortunately the clks don't have
432 * any device tied to them, so there's no place to store the
433 * pointer to the I/O region base address. We have to fetch
434 * it from one of the registered clks.
435 */
436 base = mtk_clk_pll_get_base(clk_data->clks[pll->id], pll);
437
438 mtk_clk_unregister_pll(clk_data->clks[pll->id]);
439 clk_data->clks[pll->id] = ERR_PTR(-ENOENT);
440 }
441
442 iounmap(base);
443 }
444 EXPORT_SYMBOL_GPL(mtk_clk_unregister_plls);
445

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-04-04 13:43    [W:0.033 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site