Messages in this thread | | | Date | Mon, 4 Apr 2022 10:02:17 +0200 | Subject | Re: [PATCH V2] Fix unsafe memory access by memcmp | From | Michael Straube <> |
| |
On 4/4/22 04:52, Charlie Sands wrote: > This patch fixes sparse warnings about the memcmp function unsafely > accessing userspace memory without first copying it to kernel space. > > Signed-off-by: Charlie Sands <sandsch@northvilleschools.net> > --- > > V2: Fixed checkpatch.pl warning and changed variable name as suggested > by Greg K. H. and improved error checking on the "copy_from_user" function as > suggested by Pavel Skripkin. > > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 21 ++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) >
Hi Charlie,
thanks for your patch. Looks good to me, but you should include staging: r8188eu: in the subject line.
"staging: r8188eu: Fix unsafe memory access by memcmp"
thanks, Michael
| |