lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] scsi: message: fusion: mptbase: remove redundant variable dmp
On Thu, Mar 17, 2022 at 5:39 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> Variable dmp is being assigned a value that is never read, the
> variable is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/message/fusion/mptbase.c:6667:39: warning: Although
> the value stored to 'dmp' is used in the enclosing expression,
> the value is never actually read from 'dmp' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
> drivers/message/fusion/mptbase.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> index e90adfa57950..9b3ba2df71c7 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -6658,13 +6658,13 @@ static int mpt_summary_proc_show(struct seq_file *m, void *v)
> static int mpt_version_proc_show(struct seq_file *m, void *v)
> {
> u8 cb_idx;
> - int scsi, fc, sas, lan, ctl, targ, dmp;
> + int scsi, fc, sas, lan, ctl, targ;
> char *drvname;
>
> seq_printf(m, "%s-%s\n", "mptlinux", MPT_LINUX_VERSION_COMMON);
> seq_printf(m, " Fusion MPT base driver\n");
>
> - scsi = fc = sas = lan = ctl = targ = dmp = 0;
> + scsi = fc = sas = lan = ctl = targ = 0;
> for (cb_idx = MPT_MAX_PROTOCOL_DRIVERS-1; cb_idx; cb_idx--) {
> drvname = NULL;
> if (MptCallbacks[cb_idx]) {
> --
> 2.35.1
>
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2022-04-05 00:42    [W:0.041 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site