lkml.org 
[lkml]   [2022]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] ksmbd: fix reference count leak in smb_check_perm_dacl()
2022-04-29 17:11 GMT+09:00, Xin Xiong <xiongx18@fudan.edu.cn>:
> The issue happens in a specific path in smb_check_perm_dacl(). When
> "id" and "uid" have the same value, the function simply jumps out of
> the loop without decrementing the reference count of the object
> "posix_acls", which is increased by get_acl() earlier. This may
> result in memory leaks.
>
> Fix it by decreasing the reference count of "posix_acls" before
> jumping to label "check_access_bits".
>
> Fixes: 777cad1604d6 ("ksmbd: remove select FS_POSIX_ACL in Kconfig")
> Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>

Thanks!

\
 
 \ /
  Last update: 2022-04-30 06:16    [W:0.079 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site