lkml.org 
[lkml]   [2022]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io
On Sat, 30 Apr 2022, Christophe JAILLET wrote:

> Le 18/03/2022 à 15:52, Wan Jiabing a écrit :
> > io->sgl is allocated by kzalloc(). The memory is set to zero.
> > It is unnecessary to call memset again.
> >
>
> Hi,
>
> Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded
> multiplication when computing the size to allocate.
>

Seems like kcalloc() conversion could be a separate patch. Perhaps it
could be done everywhere using a coccinelle script.
\
 
 \ /
  Last update: 2022-04-30 09:49    [W:0.064 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site