Messages in this thread | | | Date | Sat, 30 Apr 2022 17:48:06 +1000 (AEST) | From | Finn Thain <> | Subject | Re: [PATCH] scsi: elx: efct: remove unnecessary memset in efct_io |
| |
On Sat, 30 Apr 2022, Christophe JAILLET wrote:
> Le 18/03/2022 à 15:52, Wan Jiabing a écrit : > > io->sgl is allocated by kzalloc(). The memory is set to zero. > > It is unnecessary to call memset again. > > > > Hi, > > Nitpick: this kzalloc() should be a kcalloc() to avoid an open-coded > multiplication when computing the size to allocate. >
Seems like kcalloc() conversion could be a separate patch. Perhaps it could be done everywhere using a coccinelle script. | |