lkml.org 
[lkml]   [2022]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override
On Sat, 30 Apr 2022, Stephen Zhang wrote:

> > Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
> > kernel parameter non-functional, and also causes a link error:
> >
> > ld: arch/mips/kernel/traps.o: in function `trap_init':
> > ./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
> >
> > where the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
> >
>
> Sorry, but I have a question. From the code in
> arch/mips/kernel/genex.S:567, 'handle_fpe’‘s
> definition is controlled by CONFIG_MIPS_FP_SUPPORT. Then how can it
> still report such
> error when the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.

Good catch, thanks! For some reason I inverted the condition in my mind
as I wrote the change description. I have now posted v2 with the mistake
corrected.

Maciej

\
 
 \ /
  Last update: 2022-04-30 17:10    [W:0.041 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site