Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCHv1 13/19] pinctrl/rockchip: add rk3588 support | Date | Sat, 30 Apr 2022 16:12:46 +0200 |
| |
Hi,
Am Freitag, 29. April 2022, 00:55:52 CEST schrieb Linus Walleij: > On Fri, Apr 22, 2022 at 7:09 PM Sebastian Reichel > <sebastian.reichel@collabora.com> wrote: > > > From: Jianqun Xu <jay.xu@rock-chips.com> > > > > Add pinctrl support for RK3588. > > > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > > [merged in downstream fixes, simplified register lookup logic for better > > maintanence at the cost of a bit more static const memory and fixed some > > incorrect registers] > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > Patch applied, unless Heiko does some loud protesting it stays > in the tree.
I'm never loud ;-)
Patch looked ok overall as well. I guess at some future point someone will need to refactor the small "if rk3588" but that can be done when another slightly different user appears and we have a feeling what the common approach could look like.
Heiko
| |