lkml.org 
[lkml]   [2022]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3/4] dt-bindings: spi: add binding doc for spi-mtk-snfi
Hi!

On Sun, Apr 3, 2022 at 11:49 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> [...]
> >>> +
> >>> + ecc-engine:
> >>
> >> The nand-chip.yaml defines a nand-ecc-engine, so how about using that
> >> one? I know mtk-nand.txt uses ecc-engine, but for new schema better to
> >> use properties from existing YAML.
> >
> > The ecc-engine code is shared between mtk_nand.c and this driver, and
> > the property name is defined in the shared part. I left it as-is so that
> > existing dt for mtk_nand doesn't break.
>
> This can be easily fixed with:
> np = of_parse_phandle(of_node, "nand-ecc-engine", 0);
> if (!np) {
> /* Backwards compatible */
> np = of_parse_phandle(of_node, "ecc-engine", 0);
> }
>
> I would like to avoid having one property in generic NAND schema and
> keep adding something slightly different everywhere else.

OK. I'll add a commit for this in the next version.

--
Regards,
Chuanhong Guo

\
 
 \ /
  Last update: 2022-04-03 18:02    [W:0.031 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site