Messages in this thread Patch in this message | | | Date | Sun, 3 Apr 2022 15:16:20 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR |
| |
On Thu, Mar 31, 2022 at 03:24:37PM +0200, Borislav Petkov wrote: > diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c > index 1940d305db1c..a1a4a5dc53e8 100644 > --- a/arch/x86/kernel/cpu/mce/amd.c > +++ b/arch/x86/kernel/cpu/mce/amd.c > @@ -722,6 +722,19 @@ bool amd_mce_is_memory_error(struct mce *m) > return m->bank == 4 && xec == 0x8; > } > > +/* Extract [55:<lsb>] where lsb is the LS-*valid* bit of the address bits. */ > +void smca_extract_err_addr(struct mce *m)
In addition:
diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c index 9ccc2ea0ea00..4acc7959be6e 100644 --- a/arch/x86/kernel/cpu/mce/amd.c +++ b/arch/x86/kernel/cpu/mce/amd.c @@ -723,7 +723,7 @@ bool amd_mce_is_memory_error(struct mce *m) } /* Extract [55:<lsb>] where lsb is the LS-*valid* bit of the address bits. */ -void smca_extract_err_addr(struct mce *m) +void __always_inline smca_extract_err_addr(struct mce *m) { u8 lsb; because some compilers cause:
vmlinux.o: warning: objtool: mce_read_aux()+0x82: call to smca_extract_err_addr() leaves .noinstr.text section
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |