Messages in this thread | | | Date | Fri, 29 Apr 2022 12:46:11 -0300 | Subject | Re: [PATCH 11/30] um: Improve panic notifiers consistency and ordering | From | "Guilherme G. Piccoli" <> |
| |
On 28/04/2022 05:30, Johannes Berg wrote: > [trimming massive CC list] > > On Wed, 2022-04-27 at 19:49 -0300, Guilherme G. Piccoli wrote: >> >> Also, we remove a useless header inclusion. > > I wouldn't say it's useless, generally we try not to rely on implicit > includes so much? And you at least now use NOTIFY_DONE from it. > > Otherwise looks fine to me. > > johannes
Hi Johannes, thanks for your prompt response, and for clearing a bit the *huge* CC list, it got really humongous...
I agree with you here - I missed that there's also a reboot notifier in "mconsole_kern.c", so seems it makes sense to keep the header. I'll fix that for V2, ok? If it was only a panic notifier I would consider it useless maybe, but we have non-panic notifier as well heh
Cheers,
Guilherme
| |