lkml.org 
[lkml]   [2022]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] Enable JPEG Encoder on RK3566/RK3568
From
Date
Le jeudi 28 avril 2022 à 00:44 +0200, Nicolas Frattaroli a écrit :
> Hello,
>
> the following series adds support for and enables the hardware JPEG
> encoder on the RK3566 and RK3568 line of SoCs by Rockchip.
>
> The JPEG encoder is its own little Hantro instance with seemingly just
> the encode functionality.

I'm a little suspicious about this statement. I believe the Hantro combo is
identical to RK3399 and that you are confusing with Rockchip JPEG encoder here.
Here's the source of my suspicion:

https://github.com/JeffyCN/rockchip_mirrors/blob/mpp/osal/mpp_soc.cpp#L637

As this get burnt into DT, we really need to get this right. Perhaps we need to
run the reference software to verify ? Ping me if you need help with that.

>
> The first patch modifies the bindings with a new compatible, and adds
> the ability to just have a vepu interrupt without a vdpu interrupt.
>
> The second patch makes the actual driver changes to support this variant.
>
> The third and final patch makes the necessary device tree changes for
> the rk356x device tree file to add both the node for the encoder and
> its MMU.
>
> The series has been tested on a PINE64 Quartz64 Model A with an RK3566
> SoC using GStreamer.
>
> Regards,
> Nicolas Frattaroli
>
> Nicolas Frattaroli (3):
> dt-bindings: media: rockchip-vpu: Add RK3568 JPEG compatible
> media: hantro: Add support for RK356x JPEG encoder
> arm64: dts: rockchip: Add JPEG encoder node to rk356x
>
> .../bindings/media/rockchip-vpu.yaml | 2 +
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 21 +++++++
> drivers/staging/media/hantro/hantro_drv.c | 1 +
> drivers/staging/media/hantro/hantro_hw.h | 1 +
> .../staging/media/hantro/rockchip_vpu_hw.c | 62 +++++++++++++++++++
> 5 files changed, 87 insertions(+)
>

\
 
 \ /
  Last update: 2022-04-29 16:47    [W:0.084 / U:2.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site