lkml.org 
[lkml]   [2022]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: cadence-quadspi: fix Direct Access Mode disable for SoCFPGA
On 27/04/22 04:34PM, Ian Abbott wrote:
> The Cadence QSPI compatible string required for the SoCFPGA platform
> changed from the default "cdns,qspi-nor" to "intel,socfpga-qspi" with
> the introduction of an additional quirk in
> commit 98d948eb8331 ("spi: cadence-quadspi: fix write completion support").
> However, that change did not preserve the previously used
> quirk for this platform. Reinstate the `CQSPI_DISABLE_DAC_MODE` quirk
> for the SoCFPGA platform.
>
> Fixes: 98d948eb8331 ("spi: cadence-quadspi: fix write completion support")
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

> ---
> drivers/spi/spi-cadence-quadspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
> index 41922a5ea1f4..30307392c75a 100644
> --- a/drivers/spi/spi-cadence-quadspi.c
> +++ b/drivers/spi/spi-cadence-quadspi.c
> @@ -1781,7 +1781,7 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = {
> };
>
> static const struct cqspi_driver_platdata socfpga_qspi = {
> - .quirks = CQSPI_NO_SUPPORT_WR_COMPLETION,
> + .quirks = CQSPI_DISABLE_DAC_MODE | CQSPI_NO_SUPPORT_WR_COMPLETION,
> };
>
> static const struct cqspi_driver_platdata versal_ospi = {
> --
> 2.35.1
>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.

\
 
 \ /
  Last update: 2022-04-29 07:59    [W:0.066 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site