Messages in this thread | | | Date | Fri, 29 Apr 2022 13:25:37 +0300 | Subject | Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data() | From | Tomi Valkeinen <> |
| |
On 29/04/2022 12:01, cgel.zte@gmail.com wrote: > From: Minghao Chi <chi.minghao@zte.com.cn> > > Simplify the return expression. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn> > --- > drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c > index eea719243eaf..10c6b3e492d3 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c > @@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss, > { > struct dss_pll *pll = &hpll->pll; > struct clk *clk; > - int r; > > clk = devm_clk_get(&pdev->dev, "sys_clk"); > if (IS_ERR(clk)) { > @@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss, > > pll->ops = &hdmi_pll_ops; > > - r = dss_pll_register(dss, pll); > - if (r) > - return r; > - > - return 0; > + return dss_pll_register(dss, pll); > }
This is a rather pointless change, and I personally like the current style better.
Tomi
| |