Messages in this thread | | | From | Radhey Shyam Pandey <> | Subject | RE: [PATCH 2/2] net: emaclite: Add error handling for of_address_to_resource() | Date | Fri, 29 Apr 2022 04:52:08 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Friday, April 29, 2022 6:48 AM > To: Radhey Shyam Pandey <radheys@xilinx.com> > Cc: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com; Michal > Simek <michals@xilinx.com>; netdev@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git <git@xilinx.com>; > Shravya Kumbham <shravyak@xilinx.com> > Subject: Re: [PATCH 2/2] net: emaclite: Add error handling for > of_address_to_resource() > > On Thu, Apr 28, 2022 at 09:57:58PM +0530, Radhey Shyam Pandey wrote: > > From: Shravya Kumbham <shravya.kumbham@xilinx.com> > > > > check the return value of of_address_to_resource() and also add > > missing of_node_put() for np and npp nodes. > > > > Addresses-Coverity: Event check_return value. > > Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com> > > Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> > > --- > > drivers/net/ethernet/xilinx/xilinx_emaclite.c | 15 ++++++++++++--- > > 1 files changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > index f9cf86e..c281423 100644 > > --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c > > @@ -803,7 +803,7 @@ static int xemaclite_mdio_write(struct mii_bus *bus, > int phy_id, int reg, > > static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) > > { > > struct mii_bus *bus; > > - int rc; > > + int rc, ret; > > struct resource res; > > struct device_node *np = of_get_parent(lp->phy_node); > > struct device_node *npp; > > Reverse Chritmas tree is messed up here, but you could make it a bet > less messed up by moving rc, ret further down.
Thanks, I will fix the existing declaration order in a new patch. and in this patch will align new changes to reverse Christmas tree order.
> > Andrew
| |