lkml.org 
[lkml]   [2022]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 01/17] drm/panfrost: Put mapping instead of shmem obj on panfrost_mmu_map_fault_addr() error
From
On 24/04/2022 20:04, Dmitry Osipenko wrote:
> When panfrost_mmu_map_fault_addr() fails, the BO's mapping should be
> unreferenced and not the shmem object that backs that mapping.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Fixes: bdefca2d8dc0 ("drm/panfrost: Add the panfrost_gem_mapping concept")

Reviewed-by: Steven Price <steven.price@arm.com>

Thanks,

Steve

> ---
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_mmu.c b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> index d3f82b26a631..b285a8001b1d 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_mmu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_mmu.c
> @@ -518,7 +518,7 @@ static int panfrost_mmu_map_fault_addr(struct panfrost_device *pfdev, int as,
> err_pages:
> drm_gem_shmem_put_pages(&bo->base);
> err_bo:
> - drm_gem_object_put(&bo->base.base);
> + panfrost_gem_mapping_put(bomapping);
> return ret;
> }
>

\
 
 \ /
  Last update: 2022-04-28 15:20    [W:0.126 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site