Messages in this thread | | | Date | Thu, 28 Apr 2022 17:00:07 +0530 | Subject | Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial | From | Sai Prakash Ranjan <> |
| |
On 4/28/2022 4:20 PM, Greg KH wrote: > On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote: >> Disable MMIO tracing for geni serial driver as it is a high >> frequency operation for serial driver with many register reads/ >> writes and not very useful to log all MMIO traces and prevent >> excessive logging. >> >> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> >> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com> >> --- >> drivers/tty/serial/qcom_geni_serial.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c >> index 1543a6028856..5b48e6c2bf3c 100644 >> --- a/drivers/tty/serial/qcom_geni_serial.c >> +++ b/drivers/tty/serial/qcom_geni_serial.c >> @@ -1,5 +1,11 @@ >> // SPDX-License-Identifier: GPL-2.0 >> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved. >> +/* >> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ > I strongly disagree that adding a single line here warrants a copyright > update. If your lawyers will sign off on this change, I am willing to > reconsider. >
You are right, I checked with them and they mentioned copyright update is not required for a one line change.
>> + >> +/* Disable MMIO tracing */ > Please say why in the comment, not just what. >
Hmm the changelog describes it but I can add a comment as well.
Thanks, Sai
| |