Messages in this thread | | | Date | Thu, 28 Apr 2022 07:53:04 +0200 | From | Greg KH <> | Subject | Re: [PATCHv11 6/6] asm-generic/io: Add logging support for MMIO accessors |
| |
On Thu, Apr 28, 2022 at 09:00:13AM +0530, Sai Prakash Ranjan wrote: > Add logging support for MMIO high level accessors such as read{b,w,l,q} > and their relaxed versions to aid in debugging unexpected crashes/hangs > caused by the corresponding MMIO operation. Also add a generic flag > (__DISABLE_TRACE_MMIO__) which is used to disable MMIO tracing in nVHE KVM > and if required can be used to disable MMIO tracing for specific drivers.
Also, this should be split up into 2 patches, one to add the "disable the feature" flag, and one to enable it for the specific driver(s) you want.
Hint, when you say "also" in a changelog text, that's a huge sign that it perhaps should be split up into smaller pieces.
thanks,
greg k-h
| |