Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2] ipc: Update semtimedop() to use hrtimer | Date | Thu, 28 Apr 2022 21:26:55 +0200 |
| |
Prakash,
On Thu, Apr 28 2022 at 08:07, Prakash Sangappa wrote: > semtimedop() should be converted to use hrtimer like it has been done > for most of the system calls with timeouts. This system call already > takes a struct timespec as an argument and can therefore provide finer > granularity timed wait.
almost perfect :)
The v1->v2: description wants to be below the '---' separator. It's not part of the changelog and just helpful for reviewers to assess the history of the patch(set).
> v1->v2: > - Use timespec64_valid() to validate timeout > and other changes as suggested by Thomas Gleixner > > Signed-off-by: Prakash Sangappa <prakash.sangappa@oracle.com> > --- ... > @@ -2210,7 +2209,7 @@ long __do_semtimedop(int semid, struct sembuf *sops, > /* > * If an interrupt occurred we have to clean up the queue. > */ > - if (timeout && jiffies_left == 0) > + if (timed_out) > error = -EAGAIN; > } while (error == -EINTR && !signal_pending(current)); /* spurious */
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
| |