Messages in this thread | | | Date | Wed, 27 Apr 2022 08:37:41 +0200 | From | Greg KH <> | Subject | Re: [EXT] Re: [PATCH] Uwb: Nxp: sr1xx: Uwb driver support for sr1xx series chip |
| |
On Wed, Apr 27, 2022 at 06:24:14AM +0000, Manjunatha Venkatesh wrote: > Hello Greg, > > Thanks for sharing your comments with us and apologies for our delayed > response. > We have done a thorough review internally and would like to put forward a > proposal for your consideration. > > 1) In our next submission we will define the kernel/user API clearly with > kernel pre-defined IOCTL macros in the uapi header file and follow the > standard IOCTL rules.
Why do you need ioctls at all? Anyway, submit the code and we can review the api then, I have no recollection of the previous submission as it was thousands of patches ago.
> 2) We agree that this is a simple driver which may not need a dedicated > directory under Linux/drivers so we will move the driver to "misc" folder. > 3) We can also share some applications which show the usage of these driver > API's from the user space.
That's great, submit away!
greg k-h
| |