lkml.org 
[lkml]   [2022]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 5/9] iio: accel: bma400: Add separate channel for step counter
On Wed, Apr 20, 2022 at 11:11 PM Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> Added channel for step counter which can be enable or disable
> through the sysfs interface.

...

> +static int bma400_enable_steps(struct bma400_data *data, int val)
> +{
> + int ret;
> +
> + if (data->steps_enabled == val)
> + return 0;
> +
> + ret = regmap_update_bits(data->regmap, BMA400_INT_CONFIG1_REG,
> + BMA400_STEP_INT_MSK,
> + FIELD_PREP(BMA400_STEP_INT_MSK, !!val));

> + data->steps_enabled = val;

This will update the value even if we got an error and actual device
state is unknown here. Does this make sense?

> + return ret;
> +}

...

I perhaps missed why kmalloc() is needed now. Any pointers to the discussion?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-04-27 14:38    [W:0.163 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site