lkml.org 
[lkml]   [2022]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] hwmon: (asus-ec-sensors) introduce ec_board_info struct for board data
On 4/27/22 02:32, Eugene Shalygin wrote:
>> Since this is now tied to MODULE_DEVICE_TABLE(acpi, ...), I think the
>> probe function should be referenced in asus_ec_sensors_platform_driver,
>> and it should be module_platform_driver() instead of
>> module_platform_driver_probe().
>
> As follows?
>
> static struct platform_driver asus_ec_sensors_platform_driver_probe = {
> .probe = asus_ec_probe,
> .driver = {
> .name = "asus-ec-sensors",
> .acpi_match_table = acpi_ec_ids,
> },
> };
>
> MODULE_DEVICE_TABLE(acpi, acpi_ec_ids);
> module_platform_driver(asus_ec_sensors_platform_driver_probe);
>
> The "_probe" suffix added to keep the asus_ec_probe() code and its
> deps as __init.
>

Sorry, I don't follow that part. One can add "__init" or "__initdata",
as in

static struct platform_driver asus_ec_sensors_platform_driver __initdata = {

to mark a function or data structure as __init. I don't think adding
"_probe" to the struct platform_driver variable name does that.

Guenter

\
 
 \ /
  Last update: 2022-04-27 14:07    [W:0.089 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site