lkml.org 
[lkml]   [2022]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 03/16] block: add bdev_zone_no helper
    From
    On 4/28/22 01:02, Pankaj Raghav wrote:
    > Many places in the filesystem for zoned devices open code this function
    > to find the zone number for a given sector with power of 2 assumption.
    > This generic helper can be used to calculate zone number for a given
    > sector in a block device
    >
    > This helper internally uses blk_queue_zone_no to find the zone number.
    >
    > Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
    > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
    > ---
    > include/linux/blkdev.h | 9 +++++++++
    > 1 file changed, 9 insertions(+)
    >
    > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
    > index f8f2d2998afb..55293e0a8702 100644
    > --- a/include/linux/blkdev.h
    > +++ b/include/linux/blkdev.h
    > @@ -1392,6 +1392,15 @@ static inline bool bdev_zone_aligned(struct block_device *bdev, sector_t sec)
    > return false;
    > }
    >
    > +static inline unsigned int bdev_zone_no(struct block_device *bdev, sector_t sec)
    > +{
    > + struct request_queue *q = bdev_get_queue(bdev);
    > +
    > + if (q)

    q is never NULL. So this can be simplified to:

    return blk_queue_zone_no(bdev_get_queue(bdev), sector);

    > + return blk_queue_zone_no(q, sec);
    > + return 0;
    > +}
    > +
    > static inline unsigned int bdev_max_open_zones(struct block_device *bdev)
    > {
    > struct request_queue *q = bdev_get_queue(bdev);


    --
    Damien Le Moal
    Western Digital Research

    \
     
     \ /
      Last update: 2022-04-28 01:32    [W:4.194 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site