lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 44/86] dpaa_eth: Fix missing of_node_put in dpaa_get_ts_info()
    Date
    From: Lv Ruyi <lv.ruyi@zte.com.cn>

    [ Upstream commit 1a7eb80d170c28be2928433702256fe2a0bd1e0f ]

    Both of of_get_parent() and of_parse_phandle() return node pointer with
    refcount incremented, use of_node_put() on it to decrease refcount
    when done.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
    index 1268996b7030..2f9075429c43 100644
    --- a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
    +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c
    @@ -489,11 +489,15 @@ static int dpaa_get_ts_info(struct net_device *net_dev,
    info->phc_index = -1;

    fman_node = of_get_parent(mac_node);
    - if (fman_node)
    + if (fman_node) {
    ptp_node = of_parse_phandle(fman_node, "ptimer-handle", 0);
    + of_node_put(fman_node);
    + }

    - if (ptp_node)
    + if (ptp_node) {
    ptp_dev = of_find_device_by_node(ptp_node);
    + of_node_put(ptp_node);
    + }

    if (ptp_dev)
    ptp = platform_get_drvdata(ptp_dev);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-04-26 11:04    [W:4.101 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site