lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition
From
On 4/26/22 01:27, liuxp11@chinatelecom.cn wrote:
> On 4/26/22 00:10, Liu Xinpeng wrote:
> > Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.
> >
> > Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> > Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
> Also, Tzung-Bi never sent a Reviewed-by: tag. As with the other patches,
> this is completely inappropriate. Really, who gave you that idea ?
> You adding such tags without receiving them means we can never trust
> your patches again since you are making things up.
> Guenter
> -->Very sorry about this. I am not clearly when need to add "Reviewed-by: tag",
> Just expressing thanks.
>

If you get a Reviewed-by: tag for a patch, you keep it in the next version of
that patch unless there are substantial changes. You _never_ add one yourself.

Guenter

\
 
 \ /
  Last update: 2022-04-26 10:58    [W:0.152 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site