Messages in this thread | | | Subject | Re: [PATCH] net: dsa: mv88e6xxx: Skip cmode writable for mv88e6*41 if unchanged | From | Paolo Abeni <> | Date | Tue, 26 Apr 2022 09:50:15 +0200 |
| |
Hello,
On Sat, 2022-04-23 at 15:25 +0200, Marek Behún wrote: > On Sat, 23 Apr 2022 13:20:35 +0000 > Nathan Rossi <nathan@nathanrossi.com> wrote: > > > The mv88e6341_port_set_cmode function always calls the set writable > > regardless of whether the current cmode is different from the desired > > cmode. This is problematic for specific configurations of the mv88e6341 > > and mv88e6141 (in single chip adddressing mode?) where the hidden > > registers are not accessible. > > I don't have a problem with skipping setting cmode writable if cmode is > not being changed. But hidden registers should be accessible regardless > of whether you are using single chip addressing mode or not. You need > to find why it isn't working for you, this is a bug.
For the records, I read the above as requiring a fix the root cause, so I'm not applying this patch. Please correct me if I'm wrong.
Thanks,
Paolo
| |