Messages in this thread | | | Date | Tue, 26 Apr 2022 11:40:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH v3 1/2] staging: r8188eu: fix potential memory leak in _rtw_init_xmit_priv() |
| |
On Fri, Apr 08, 2022 at 09:37:10AM +0800, xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang <xkernel.wang@foxmail.com> > > In _rtw_init_xmit_priv(), there are several error paths for allocation > failures just jump to the `exit` section. However, there is no action > will be performed, so the allocated resources are not properly released, > which leads to various memory leaks. > > To properly release them, this patch unifies the error handling code and > several error handling paths are added. > According to the allocation sequence, if the validation fails, it will > jump to its corresponding error tag to release the resources. > > Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com> > --- > ChangeLog: > v1->v2 update the description and adjust the sequence of patches. > v2->v3 None to this patch, but some to another pathch in this series. > drivers/staging/r8188eu/core/rtw_xmit.c | 32 ++++++++++++++++++------- > 1 file changed, 24 insertions(+), 8 deletions(-)
I still have 12 patches in my queue from you, yet no idea which order they belong in at all, nor which is the latest versions :(
Please rebase and resubmit them ALL as a single patch series so I can have a hint as to what to do here.
thanks,
greg k-h
| |