lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq: mediatek: Fix NULL pointer dereference in mediatek-cpufreq
On 26-04-22, 19:17, Wan Jiabing wrote:
> Fix following coccicheck error:
> drivers/cpufreq/mediatek-cpufreq.c:464:16-23: ERROR: info is NULL but dereferenced.
>
> Use pr_err instead of dev_err to avoid dereferring a NULL pointer.
>
> Fixes: f52b16ba9fe4 ("cpufreq: mediatek: Use device print to show logs")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index bcabb3726a5b..901042e9a240 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -461,8 +461,8 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy)
>
> info = mtk_cpu_dvfs_info_lookup(policy->cpu);
> if (!info) {
> - dev_err(info->cpu_dev,
> - "dvfs info for cpu%d is not initialized.\n", policy->cpu);
> + pr_err("dvfs info for cpu%d is not initialized.\n",
> + policy->cpu);
> return -EINVAL;
> }

Applied. Thanks.

--
viresh

\
 
 \ /
  Last update: 2022-04-27 05:19    [W:0.471 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site