lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 6/9] x86: resctrl: pseudo_lock: Fix to restore to original value when re-enabling hardware prefetch register
Date
Thanks for the comment.

> Thank you very much for catching this issue. This fix is not specific to or required
> by the driver you are creating in this series so you could also extract this patch and
> submit it separately as a fix to resctrl.

I would like to send this patch separated from this series next time.

> When you do resubmit there are a few style related points that I highlight here, the
> fix itself looks good.
>
> For the subject, please use "x86/resctrl:" prefix in the subject.

> This needs a Fixes tag. A few patches are impacted by this fix:
>
> Fixes: 018961ae5579 ("x86/intel_rdt: Pseudo-lock region creation/removal
> core")
> Fixes: 443810fe6160 ("x86/intel_rdt: Create debugfs files for pseudo-locking
> testing")
> Fixes: 8a2fc0e1bc0c ("x86/intel_rdt: More precise L2 hit/miss measurements")

I would like to use this prefix and add Fixes tag for the next patch.

> Please do follow the current style of using "reverse fir tree order".
> More information in:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docume
> ntation/process/maintainer-tip.rst#n587

> Same as above.

I check the URL to fix style problem.
\
 
 \ /
  Last update: 2022-04-27 04:53    [W:0.117 / U:1.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site