Messages in this thread | | | From | Cixi Geng <> | Date | Wed, 27 Apr 2022 09:23:06 +0800 | Subject | Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table |
| |
Lee Jones <lee.jones@linaro.org> 于2022年4月26日周二 22:44写道: > > On Mon, 25 Apr 2022, Cixi Geng wrote: > > > From: Cixi Geng <cixi.geng1@unisoc.com> > > > > Add the SC2730 PMIC support for module autoloading > > through SPI modalises. > > > > Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com> > > --- > > drivers/mfd/sprd-sc27xx-spi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > > index 55d2c31bdfb2..cf4f89114ae4 100644 > > --- a/drivers/mfd/sprd-sc27xx-spi.c > > +++ b/drivers/mfd/sprd-sc27xx-spi.c > > @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match); > > > > static const struct spi_device_id sprd_pmic_spi_ids[] = { > > { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data }, > > + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data }, > > Nicer if these were ordered with the smallest number at the top. I followed the order of struct of_device_id sprd_pmic_match[1],Do I need adjust it as well? [1].https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/mfd/sprd-sc27xx-spi.c#L242 > > > {}, > > }; > > MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids); > > -- > Lee Jones [李琼斯] > Principal Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
| |