Messages in this thread | | | Date | Tue, 26 Apr 2022 15:41:43 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v2] Input: cros-ec-keyb: Only register keyboard if rows/columns exist |
| |
On Mon, Apr 25, 2022 at 02:07:26PM -0700, Stephen Boyd wrote: > If the device is a detachable, we may still probe this device because > there are some button switches, e.g. volume buttons and power buttons, > registered by this driver. Let's allow the device node to be missing row > and column device properties to indicate that the keyboard matrix > shouldn't be registered. This removes an input device on Trogdor devices > such as Wormdingler that don't have a matrix keyboard, but still have > power and volume buttons. That helps userspace understand there isn't > a keyboard present when the detachable keyboard is disconnected. > > Cc: Benson Leung <bleung@chromium.org> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Hsin-Yi Wang <hsinyi@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Applied, thank you.
-- Dmitry
| |