Messages in this thread | | | From | Rob Herring <> | Date | Tue, 26 Apr 2022 17:04:50 -0500 | Subject | Re: [PATCH v5 04/11] clocksource/drivers: Add HPE GXP timer |
| |
On Tue, Apr 26, 2022 at 4:55 PM Arnd Bergmann <arnd@arndb.de> wrote: > > On Tue, Apr 26, 2022 at 11:38 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Apr 26, 2022 at 08:00:20AM +0200, Arnd Bergmann wrote: > > > On Mon, Apr 25, 2022 at 10:38 PM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > There are multiple ways of doing this that we already discussed > > > in the thread. The easiest is probably to have a child node without > > > custom registers in the DT and then use the DT helpers to > > > populate the linux devices with the correct data. > > > > I think that's what the wdt binding is doing, but I don't like that. > > Maybe it's not a child node, I can't tell. > > > > Bindings should not be decided on the *current* driver split on one > > particular OS. This looks like 1 block, so 1 node. > > Fair enough. > > > If that doesn't work well or easy for Linux, then we should fix Linux. > > Doing a simple platform_device_create_pdata() should work fine here, > the only problem that might exist is if the wdt driver needs access to > DT properties, as we can't have both devices refer to the same of_node > pointer,
Why not? There's even a struct device flag for that.
> which would cause them to be picked up by the timer driver > again.
Huh?
That's not to say there might be some gotchas. The musb driver didn't like sharing. But those are issues we should fix rather than work-around in the binding.
Rob
| |