Messages in this thread | | | From | Eugene Shalygin <> | Date | Tue, 26 Apr 2022 23:50:47 +0200 | Subject | Re: [PATCH v2 3/4] hwmon: (asus-ec-sensors) add support for board families |
| |
> > +enum board_family { > > + family_amd_500_series, > > The default enum value is 0. This means that specifying nothing > for .family matches in the structure below always matches the first > enum, which doesn't make much sense and might cause trouble in the > future. I would suggest to explicitly select a value != 0 as first > entry, such as > > enum board_family { > family_amd_500_series = 1, > ... > }; > > to avoid that problem.
Thank you, added family_unknown member ( = 0) instead, to simplify adding new members (I want this enum to be alphabetically sorted).
Eugene
| |