Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v3 1/2] lib/kstrtox.c: Add "false"/"true" support to kstrtobool() | Date | Tue, 26 Apr 2022 20:40:31 +0000 |
| |
From: Matthew Wilcox > Sent: 26 April 2022 20:15 () > > On Tue, Apr 26, 2022 at 11:32:02PM +0530, Jagdish Gediya wrote: > > Signed-off-by: Jagdish Gediya <jvgediya@linux.ibm.com> > > Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > HEY! You still have the buggy IFF -> IF change. FIX IT. > My R-b was very clearly conditional on you fixing it. > > > - * This routine returns 0 iff the first character is one of 'Yy1Nn0', or > > + * This routine returns 0 if the first character is one of 'YyTt1NnFf0', or
my 2c
Iff doesn't really go with an 'or' clause. (With a maths degree I know what it means!)
so it probably reads better as 'if'.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |