Messages in this thread | | | Date | Tue, 26 Apr 2022 22:09:38 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] kernel: add platform_has() infrastructure |
| |
On Tue, Apr 26, 2022 at 09:53:42PM +0200, Heiko Carstens wrote: > > You probably should make that thing static and use only accessors to > > modify it in case you wanna change the underlying data structure in the > > future. > > That would add another indirection, which at least I think is not > necessary and would make it less likely that this infrastructure is > used.
So if you want to have a single variable which contains platform feature bits, you don't need any platform_<bla> accessors but use this variable directly.
I'd prefer the accessors any day of the week, though.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |