Messages in this thread | | | Date | Tue, 26 Apr 2022 10:23:59 +0300 | Subject | Re: [PATCH] dt-bindings: clock: qcom,gcc-apq8064: Fix typo in compatible and split apq8084 | From | Dmitry Baryshkov <> |
| |
On 25/04/2022 23:40, Krzysztof Kozlowski wrote: > The qcom,gcc-apq8064.yaml was meant to describe only APQ8064 and APQ8084 > should have slightly different bindings (without Qualcomm thermal sensor > device). > > Fixes: a469bf89a009 ("dt-bindings: clock: simplify qcom,gcc-apq8064 Documentation") > Reported-by: Rob Herring <robh@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I think we can simply move it to the gcc-other.yaml. I'll send a patch.
> --- > .../bindings/clock/qcom,gcc-apq8064.yaml | 4 +- > .../bindings/clock/qcom,gcc-apq8084.yaml | 42 +++++++++++++++++++ > 2 files changed, 43 insertions(+), 3 deletions(-) > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > index 97936411b6b4..9fafcb080069 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > @@ -20,12 +20,10 @@ description: | > See also: > - dt-bindings/clock/qcom,gcc-msm8960.h > - dt-bindings/reset/qcom,gcc-msm8960.h > - - dt-bindings/clock/qcom,gcc-apq8084.h > - - dt-bindings/reset/qcom,gcc-apq8084.h > > properties: > compatible: > - const: qcom,gcc-apq8084 > + const: qcom,gcc-apq8064 > > nvmem-cells: > minItems: 1 > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > new file mode 100644 > index 000000000000..63d08e82b3d8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8084.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,gcc-apq8084.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Global Clock & Reset Controller Binding for APQ8084 > + > +maintainers: > + - Stephen Boyd <sboyd@kernel.org> > + - Taniya Das <tdas@codeaurora.org> > + > +description: | > + Qualcomm global clock control module which supports the clocks, resets and > + power domains on APQ8064/APQ8084. > + > + See also:: > + - dt-bindings/clock/qcom,gcc-apq8084.h > + - dt-bindings/reset/qcom,gcc-apq8084.h > + > +allOf: > + - $ref: qcom,gcc.yaml# > + > +properties: > + compatible: > + const: qcom,gcc-apq8084 > + > +required: > + - compatible > + > +unevaluatedProperties: false > + > +examples: > + - | > + clock-controller@fc400000 { > + compatible = "qcom,gcc-apq8084"; > + reg = <0xfc400000 0x4000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; > +...
-- With best wishes Dmitry
| |