Messages in this thread | | | Subject | Re: [PATCH v2 6/6] selftests: vm: add /dev/userfaultfd test cases to run_vmtests.sh | From | Shuah Khan <> | Date | Tue, 26 Apr 2022 11:34:17 -0600 |
| |
On 4/22/22 3:29 PM, Axel Rasmussen wrote: > This new mode was recently added to the userfaultfd selftest. We want to > exercise both userfaultfd(2) as well as /dev/userfaultfd, so add both > test cases to the script. > > Signed-off-by: Axel Rasmussen <axelrasmussen@google.com> > --- > tools/testing/selftests/vm/run_vmtests.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 5065dbd89bdb..57f01505c719 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -121,12 +121,17 @@ run_test ./gup_test -a > run_test ./gup_test -ct -F 0x1 0 19 0x1000 > > run_test ./userfaultfd anon 20 16 > +run_test ./userfaultfd anon:dev 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half the > # size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 > +run_test ./userfaultfd hugetlb:dev "$half_ufd_size_MB" 32 > run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test > rm -f "$mnt"/uffd-test > +run_test ./userfaultfd hugetlb_shared:dev "$half_ufd_size_MB" 32 "$mnt"/uffd-test > +rm -f "$mnt"/uffd-test > run_test ./userfaultfd shmem 20 16 > +run_test ./userfaultfd shmem:dev 20 16 > > #cleanup > umount "$mnt" >
Looks good to me.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks, -- Shuah
| |