Messages in this thread | | | Date | Tue, 26 Apr 2022 16:40:32 +0100 | Subject | Re: [PATCH v1] PM: EM: Decrement policy counter | From | Vincent Donnefort <> |
| |
On 26/04/2022 15:44, Pierre Gondois wrote: > From: Pierre Gondois <Pierre.Gondois@arm.com> > > Fixes: e458716a92b57 ("PM: EM: Mark inefficiencies in CPUFreq") > In the above commit, cpufreq_cpu_get() is called without > a cpufreq_cpu_put(), permanently increasing the reference counts > of the policy struct. > Decrement the reference count once the policy struct is not used > anymore.
Not sure if the tag there will be caught properly. Usually it goes on top of the Signed-off-by.
While at it:
Reviewed-by: Vincent Donnefort <vincent.donnefort@arm.com>
Thanks for fixing this.
> > Tested-by: Cristian Marussi <cristian.marussi@arm.com> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> > --- > kernel/power/energy_model.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c > index 0153b0ca7b23..6219aaa454b5 100644 > --- a/kernel/power/energy_model.c > +++ b/kernel/power/energy_model.c > @@ -259,6 +259,8 @@ static void em_cpufreq_update_efficiencies(struct device *dev) > found++; > } > > + cpufreq_cpu_put(policy); > + > if (!found) > return; >
| |