Messages in this thread Patch in this message | | | From | Liu Xinpeng <> | Subject | [PATCH v4 4/4] watchdog: iTCO_wdg: Make code more clearly with macro definition | Date | Tue, 26 Apr 2022 15:03:08 +0800 |
| |
Using SET_NOIRQ_SYSTEM_SLEEP_PM_OPS reduces redundant code.
Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> --- drivers/watchdog/iTCO_wdt.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c index 3f2f4343644f..8d24cf4f4ca3 100644 --- a/drivers/watchdog/iTCO_wdt.c +++ b/drivers/watchdog/iTCO_wdt.c @@ -635,22 +635,18 @@ static int iTCO_wdt_resume_noirq(struct device *dev) return 0; } +#endif /* CONFIG_PM_SLEEP */ static const struct dev_pm_ops iTCO_wdt_pm = { - .suspend_noirq = iTCO_wdt_suspend_noirq, - .resume_noirq = iTCO_wdt_resume_noirq, + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(iTCO_wdt_suspend_noirq, + iTCO_wdt_resume_noirq) }; -#define ITCO_WDT_PM_OPS (&iTCO_wdt_pm) -#else -#define ITCO_WDT_PM_OPS NULL -#endif /* CONFIG_PM_SLEEP */ - static struct platform_driver iTCO_wdt_driver = { .probe = iTCO_wdt_probe, .driver = { .name = DRV_NAME, - .pm = ITCO_WDT_PM_OPS, + .pm = &iTCO_wdt_pm, }, }; -- 2.23.0
| |