Messages in this thread | | | Date | Tue, 26 Apr 2022 16:32:16 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] MIPS: SGI-IP30: Free some unused memory |
| |
On Sat, Apr 23, 2022 at 03:27:58PM +0200, Christophe JAILLET wrote: > platform_device_add_data() duplicates the memory it is passed. So we can > free some memory to save a few bytes that would remain unused otherwise. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > arch/mips/sgi-ip30/ip30-xtalk.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/sgi-ip30/ip30-xtalk.c b/arch/mips/sgi-ip30/ip30-xtalk.c > index 8a2894645529..8129524421cb 100644 > --- a/arch/mips/sgi-ip30/ip30-xtalk.c > +++ b/arch/mips/sgi-ip30/ip30-xtalk.c > @@ -63,6 +63,8 @@ static void bridge_platform_create(int widget, int masterwid) > } > platform_device_add_resources(pdev, &w1_res, 1); > platform_device_add_data(pdev, wd, sizeof(*wd)); > + /* platform_device_add_data() duplicates the data */ > + kfree(wd); > platform_device_add(pdev); > > bd = kzalloc(sizeof(*bd), GFP_KERNEL); > @@ -92,6 +94,8 @@ static void bridge_platform_create(int widget, int masterwid) > bd->io_offset = IP30_SWIN_BASE(widget); > > platform_device_add_data(pdev, bd, sizeof(*bd)); > + /* platform_device_add_data() duplicates the data */ > + kfree(bd); > platform_device_add(pdev); > pr_info("xtalk:%x bridge widget\n", widget); > return; > -- > 2.32.0
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |