lkml.org 
[lkml]   [2022]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 06/11] dt-bindings: watchdog: Add HPE GXP Watchdog timer binding
    From
    On 26/04/2022 15:21, Hawkins, Nick wrote:
    >> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions.
    >
    > It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node.

    I have impression my feedback was about mapping entire address space,
    not few registers of watchdog:
    https://lore.kernel.org/all/c6309ed8-6e74-67d3-304a-f5399d16cc37@canonical.com/

    However later during talks it turned out that the address space is
    heavily shared.

    Nick,
    BTW, do you see my comments in the email I linked above? This v5 makes
    the same mistake. We talked about this already, so please make note of
    comments you receive and implement them.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-04-26 15:36    [W:3.667 / U:0.964 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site