Messages in this thread | | | Date | Mon, 25 Apr 2022 17:56:32 +0200 | Subject | Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue | From | Krzysztof Kozlowski <> |
| |
On 19/04/2022 23:16, Allen Pais wrote: > The tasklet is an old API which will be deprecated, workqueue API > cab be used instead of them. >
Thank you for your patch. There is something to discuss/improve.
> This patch replaces the tasklet usage in drivers/dma/* with a > simple work.
Minor nits:
1. Don't use "this patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 2. Use subject prefix matching subsystem (git log --oneline)
> > Github: https://github.com/KSPP/linux/issues/94
3. No external references to some issue management systems, change-ids etc. Lore link could work, but it's not relevant here, I guess.
Best regards, Krzysztof
| |