lkml.org 
[lkml]   [2022]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue
    From
    On 19/04/2022 23:16, Allen Pais wrote:
    > The tasklet is an old API which will be deprecated, workqueue API
    > cab be used instead of them.
    >

    Thank you for your patch. There is something to discuss/improve.

    > This patch replaces the tasklet usage in drivers/dma/* with a
    > simple work.

    Minor nits:

    1. Don't use "this patch".
    https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
    2. Use subject prefix matching subsystem (git log --oneline)

    >
    > Github: https://github.com/KSPP/linux/issues/94

    3. No external references to some issue management systems, change-ids
    etc. Lore link could work, but it's not relevant here, I guess.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-04-25 17:58    [W:2.459 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site