lkml.org 
[lkml]   [2022]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] tee: remove flags TEE_IOCTL_SHM_MAPPED and TEE_IOCTL_SHM_DMA_BUF
On Mon, 25 Apr 2022 at 19:46, Andrew Davis <afd@ti.com> wrote:
>
> These look to be leftover from an early edition of this driver. Userspace
> does not need this information. Checking all users of this that I have
> access to I have verified no one is using them.
>
> They leak internal use flags out to userspace. Even more they are not
> correct anymore after a45ea4efa358. Lets drop these flags before
> someone does try to use them for something and they become ABI.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes from v1:
> - Removed flags return from tee_ioctl_shm_alloc()
>

Acked-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> drivers/tee/tee_core.c | 2 --
> include/uapi/linux/tee.h | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
> index 8aa1a4836b92f..af0f7c603fa46 100644
> --- a/drivers/tee/tee_core.c
> +++ b/drivers/tee/tee_core.c
> @@ -302,7 +302,6 @@ static int tee_ioctl_shm_alloc(struct tee_context *ctx,
> return PTR_ERR(shm);
>
> data.id = shm->id;
> - data.flags = shm->flags;
> data.size = shm->size;
>
> if (copy_to_user(udata, &data, sizeof(data)))
> @@ -339,7 +338,6 @@ tee_ioctl_shm_register(struct tee_context *ctx,
> return PTR_ERR(shm);
>
> data.id = shm->id;
> - data.flags = shm->flags;
> data.length = shm->size;
>
> if (copy_to_user(udata, &data, sizeof(data)))
> diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h
> index 25a6c534beb1b..23e57164693c4 100644
> --- a/include/uapi/linux/tee.h
> +++ b/include/uapi/linux/tee.h
> @@ -42,10 +42,6 @@
> #define TEE_IOC_MAGIC 0xa4
> #define TEE_IOC_BASE 0
>
> -/* Flags relating to shared memory */
> -#define TEE_IOCTL_SHM_MAPPED 0x1 /* memory mapped in normal world */
> -#define TEE_IOCTL_SHM_DMA_BUF 0x2 /* dma-buf handle on shared memory */
> -
> #define TEE_MAX_ARG_SIZE 1024
>
> #define TEE_GEN_CAP_GP (1 << 0)/* GlobalPlatform compliant TEE */
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2022-04-25 16:20    [W:0.195 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site