lkml.org 
[lkml]   [2022]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/4] mm/migration: remove unneeded lock page and PageMovable check
    Date
    When non-lru movable page was freed from under us, __ClearPageMovable must
    have been done. Even if it's not done, ClearPageIsolated here won't hurt
    as page will be freed anyway. So we can thus remove unneeded lock page and
    PageMovable check here.

    Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    ---
    mm/migrate.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/mm/migrate.c b/mm/migrate.c
    index b779646665fe..0fc4651b3e39 100644
    --- a/mm/migrate.c
    +++ b/mm/migrate.c
    @@ -1093,12 +1093,8 @@ static int unmap_and_move(new_page_t get_new_page,
    /* page was freed from under us. So we are done. */
    ClearPageActive(page);
    ClearPageUnevictable(page);
    - if (unlikely(__PageMovable(page))) {
    - lock_page(page);
    - if (!PageMovable(page))
    - ClearPageIsolated(page);
    - unlock_page(page);
    - }
    + if (unlikely(__PageMovable(page)))
    + ClearPageIsolated(page);
    goto out;
    }

    --
    2.23.0
    \
     
     \ /
      Last update: 2022-04-25 15:30    [W:4.051 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site