lkml.org 
[lkml]   [2022]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/6] drivers/base/node: cleanup register_node()
Date
On Fri, Apr 15, 2022 at 10:38:57PM -0700, Davidlohr Bueso wrote:
> Trivially get rid of some unnecessary indentation.
>
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
> drivers/base/node.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index ec8bb24a5a22..6cdf25fd26c3 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -661,16 +661,16 @@ static int register_node(struct node *node, int num)
> node->dev.bus = &node_subsys;
> node->dev.release = node_device_release;
> node->dev.groups = node_dev_groups;
> - error = device_register(&node->dev);
>
> - if (error)
> + error = device_register(&node->dev);
> + if (error) {
> put_device(&node->dev);
> - else {
> - hugetlb_register_node(node);
> -
> - compaction_register_node(node);
> + return error;
> }
> - return error;
> +
> + hugetlb_register_node(node);
> + compaction_register_node(node);
> + return 0;
> }
>
> /**
> --
> 2.26.2
>


Looks good.

Reviewed by: Adam Manzanares <a.manzanares@samsung.com>
\
 
 \ /
  Last update: 2022-04-26 00:37    [W:2.786 / U:1.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site