lkml.org 
[lkml]   [2022]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 01/27] modpost: use snprintf() instead of sprintf() for safety
    On Sun, Apr 24, 2022 at 12:09 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
    >
    > Use snprintf() to avoid the potential buffer overflow, and also
    > check the return value to detect the too long path.
    >
    > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

    Thanks for the patch!
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

    > ---
    >
    > scripts/mod/modpost.c | 8 +++++++-
    > 1 file changed, 7 insertions(+), 1 deletion(-)
    >
    > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
    > index 522d5249d196..141370ebbfd3 100644
    > --- a/scripts/mod/modpost.c
    > +++ b/scripts/mod/modpost.c
    > @@ -2560,6 +2560,7 @@ int main(int argc, char **argv)
    >
    > for (mod = modules; mod; mod = mod->next) {
    > char fname[PATH_MAX];
    > + int ret;
    >
    > if (mod->is_vmlinux || mod->from_dump)
    > continue;
    > @@ -2578,7 +2579,12 @@ int main(int argc, char **argv)
    > add_moddevtable(&buf, mod);
    > add_srcversion(&buf, mod);
    >
    > - sprintf(fname, "%s.mod.c", mod->name);
    > + ret = snprintf(fname, sizeof(fname), "%s.mod.c", mod->name);
    > + if (ret >= sizeof(fname)) {
    > + error("%s: too long path was truncated\n", fname);
    > + continue;
    > + }
    > +
    > write_if_changed(&buf, fname);
    > }
    >
    > --
    > 2.32.0
    >


    --
    Thanks,
    ~Nick Desaulniers

    \
     
     \ /
      Last update: 2022-04-25 20:12    [W:3.751 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site