lkml.org 
[lkml]   [2022]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RESEND, PATCH] mmc: sdhci-pci-gli: A workaround to allow GL9755 to enter ASPM L1.2
On Thu, Apr 21, 2022 at 9:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Thu, 14 Apr 2022 at 11:49, Ben Chuang <benchuanggli@gmail.com> wrote:
> >
> > From: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> >
> > When GL9755 enters ASPM L1 sub-states, it will stay at L1.1 and will not
> > enter L1.2. The workaround is to toggle PM state to allow GL9755 to enter
> > ASPM L1.2.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
>
> This didn't apply cleanly, I fixed it up this time. So, applied for
> next, thanks!
>
> Kind regards
> Uffe

I forgot to rebase to v5.18rc. I will pay more attention next time. Thank you.

Best regards,
Ben

>
>
> > ---
> > drivers/mmc/host/sdhci-pci-gli.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index 97035d77c18c..52230857388f 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -137,6 +137,9 @@
> > #define PCI_GLI_9755_SerDes 0x70
> > #define PCI_GLI_9755_SCP_DIS BIT(19)
> >
> > +#define PCI_GLI_9755_PM_CTRL 0xFC
> > +#define PCI_GLI_9755_PM_STATE GENMASK(1, 0)
> > +
> > #define GLI_MAX_TUNING_LOOP 40
> >
> > /* Genesys Logic chipset */
> > @@ -597,6 +600,13 @@ static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
> > GLI_9755_CFG2_L1DLY_VALUE);
> > pci_write_config_dword(pdev, PCI_GLI_9755_CFG2, value);
> >
> > + /* toggle PM state to allow GL9755 to enter ASPM L1.2 */
> > + pci_read_config_dword(pdev, PCI_GLI_9755_PM_CTRL, &value);
> > + value |= PCI_GLI_9755_PM_STATE;
> > + pci_write_config_dword(pdev, PCI_GLI_9755_PM_CTRL, value);
> > + value &= ~PCI_GLI_9755_PM_STATE;
> > + pci_write_config_dword(pdev, PCI_GLI_9755_PM_CTRL, value);
> > +
> > gl9755_wt_off(pdev);
> > }
> >
> > --
> > 2.35.1
> >

\
 
 \ /
  Last update: 2022-04-25 02:54    [W:0.058 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site