Messages in this thread | | | Date | Sun, 24 Apr 2022 21:01:36 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf sched: simplify if-if to if-else |
| |
Em Sun, Apr 24, 2022 at 05:07:27PM +0800, Wan Jiabing escreveu: > Use if and else instead of if(A) and if (!A).
I'm now looking for a brown paper bag... There is some hope, but I'm not in a mood, will check tomorrow, but certainly this should go in, thanks!
- Arnaldo
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> > --- > tools/perf/builtin-sched.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index 646bd938927a..66f8e9318123 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -3070,8 +3070,7 @@ static int perf_sched__timehist(struct perf_sched *sched) > /* summary_only implies summary option, but don't overwrite summary if set */ > if (sched->summary_only) > sched->summary = sched->summary_only; > - > - if (!sched->summary_only) > + else > timehist_header(sched); > > err = perf_session__process_events(session); > -- > 2.35.1
--
- Arnaldo
| |