lkml.org 
[lkml]   [2022]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/27] modpost: remove stale comment about sym_add_exported()
    Date
    The description,

    it may have already been added without a
    CRC, in this case just update the CRC

    ... is no longer valid.

    In very old days, this function was used to update the CRC as well.

    Commit 040fcc819a2e ("kbuild: improved modversioning support for
    external modules") started to use a separate function (sym_update_crc)
    for updating the CRC.

    The first part, "Add an exported symbol" is correct, but it is too
    obvious from the function name. Drop this comment entirely.

    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    ---

    scripts/mod/modpost.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
    index f0d48f65fb33..c7cfeeb088f7 100644
    --- a/scripts/mod/modpost.c
    +++ b/scripts/mod/modpost.c
    @@ -387,10 +387,6 @@ static void sym_update_namespace(const char *symname, const char *namespace)
    s->namespace = namespace[0] ? NOFAIL(strdup(namespace)) : NULL;
    }

    -/**
    - * Add an exported symbol - it may have already been added without a
    - * CRC, in this case just update the CRC
    - **/
    static struct symbol *sym_add_exported(const char *name, struct module *mod,
    enum export export)
    {
    --
    2.32.0
    \
     
     \ /
      Last update: 2022-04-24 21:13    [W:3.218 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site