Messages in this thread Patch in this message | | | Date | Sun, 24 Apr 2022 19:20:46 +0200 | From | Marek Behún <> | Subject | Re: [PATCH v2] net: dsa: mv88e6xxx: Fix port_hidden_wait to account for port_base_addr |
| |
On Sun, 24 Apr 2022 15:31:43 +0000 Nathan Rossi <nathan@nathanrossi.com> wrote:
> The other port_hidden functions rely on the port_read/port_write > functions to access the hidden control port. These functions apply the > offset for port_base_addr where applicable. Update port_hidden_wait to > use the port_wait_bit so that port_base_addr offsets are accounted for > when waiting for the busy bit to change. > > Without the offset the port_hidden_wait function would timeout on > devices that have a non-zero port_base_addr (e.g. MV88E6141), however > devices that have a zero port_base_addr would operate correctly (e.g. > MV88E6390). > > Fixes: ea89098ef9a5 ("net: dsa: mv88x6xxx: mv88e6390 errata") > Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> > --- > Changes in v2: > - Add fixes > --- > drivers/net/dsa/mv88e6xxx/port_hidden.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/port_hidden.c b/drivers/net/dsa/mv88e6xxx/port_hidden.c > index b49d05f0e1..7a9f9ff6de 100644 > --- a/drivers/net/dsa/mv88e6xxx/port_hidden.c > +++ b/drivers/net/dsa/mv88e6xxx/port_hidden.c > @@ -40,8 +40,9 @@ int mv88e6xxx_port_hidden_wait(struct mv88e6xxx_chip *chip) > { > int bit = __bf_shf(MV88E6XXX_PORT_RESERVED_1A_BUSY); > > - return mv88e6xxx_wait_bit(chip, MV88E6XXX_PORT_RESERVED_1A_CTRL_PORT, > - MV88E6XXX_PORT_RESERVED_1A, bit, 0); > + return mv88e6xxx_port_wait_bit(chip, > + MV88E6XXX_PORT_RESERVED_1A_CTRL_PORT, > + MV88E6XXX_PORT_RESERVED_1A, bit, 0); > } > > int mv88e6xxx_port_hidden_read(struct mv88e6xxx_chip *chip, int block, int port,
Reviewed-by: Marek Behún <kabel@kernel.org>
| |